Fix Rails/OrderArguments cop false positives
#1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: rubocop#1501 ```shell echo 'User.order("1")' | bundle exec rubocop --stdin bug.rb -A --only Rails/OrderArguments Inspecting 1 file F Offenses: bug.rb:1:12: C: [Corrected] Rails/OrderArguments: Prefer :1 instead. (https://rails.rubystyle.guide/#order-arguments) User.order("1") ^^^ bug.rb:1:13: F: Lint/Syntax: invalid symbol (Using Ruby 3.4 parser; configure using TargetRubyVersion parameter, under AllCops) User.order(:1) bug.rb:1:13: F: Lint/Syntax: unexpected integer; expected a ) to close the arguments (Using Ruby 3.4 parser; configure using TargetRubyVersion parameter, under AllCops) User.order(:1) ^ bug.rb:1:14: F: Lint/Syntax: unexpected ')', expecting end-of-input (Using Ruby 3.4 parser; configure using TargetRubyVersion parameter, under AllCops) User.order(:1) ^ 1 file inspected, 4 offenses detected, 1 offense corrected ==================== User.order(:1) ``` The same happens for these cases: ``` order("1 ASC") # => User.order(:1) order("1 DESC") # => User.order(1: :desc) order("id ASC, 2 DESC") # => User.order(:id, 2: :desc) ``` `order("1")` can be autocorrected to `order(1)`, but this can be done separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1501
The same happens for these cases:
order("1")can be autocorrected toorder(1), but this can be done separately.Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.